Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfTexture_updateFromTexture from v2.5 is not imported #16

Closed
mgrojo opened this issue Sep 12, 2022 · 3 comments
Closed

sfTexture_updateFromTexture from v2.5 is not imported #16

mgrojo opened this issue Sep 12, 2022 · 3 comments
Labels
API bug Something isn't working

Comments

@mgrojo
Copy link
Owner

mgrojo commented Sep 12, 2022 

CSFML_GRAPHICS_API void sfTexture_updateFromTexture(sfTexture* destination, const sfTexture* source, unsigned int x, unsigned int y);
@mgrojo
Copy link
Owner Author

mgrojo commented Sep 12, 2022

Probably related to SFML/CSFML#141 so it might bring problems if it's imported and the CSFML version is prior to that solution.

@mgrojo
Copy link
Owner Author

mgrojo commented Feb 13, 2023

There's a similar problem solved too in https://github.com/SFML/CSFML/releases/tag/2.5.1

@mgrojo mgrojo added bug Something isn't working API labels Jul 8, 2023
mgrojo added a commit that referenced this issue Jul 8, 2023
@mgrojo
sfTexture_updateFromTexture is now imported
8e579c2 
Due to this issue in CSFML:
SFML/CSFML#141
the function can only invoked in CSFML versions >= 2.5.1.

My linker does not report any problem with older versions, unless the
function is actually called, but YMMV.

See issue #16
@mgrojo
Copy link
Owner Author

mgrojo commented Jul 8, 2023

There's a similar problem solved too in https://github.com/SFML/CSFML/releases/tag/2.5.1

This part is not actually a problem for ASFML, because sfContextSettings has a C convention (and not C_Pass_By_Copy), so it is already being passed as a pointer to C.

@mgrojo mgrojo closed this as completed Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgrojo