Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Webcomic attachments link to' option in customizer has no effect #352

Closed
hyetou opened this issue Oct 23, 2020 · 5 comments
Closed

'Webcomic attachments link to' option in customizer has no effect #352

hyetou opened this issue Oct 23, 2020 · 5 comments

Comments

@hyetou
Copy link

hyetou commented Oct 23, 2020

My comic images currently link to themselves, and I am trying to stop this. In my searches, I found another thread with the same problem, and you directed them to Appearance -> Customize -> Webcomic -> Navigation -> "Webcomic attachments link to". However whether I choose 'Nothing', 'Next Webcomic', or 'Previous Webcomic', it has no effect. The image always links to itself. I have confirmed that it's not a caching issue. Thanks for any help.

Inkblot Theme 4.5.2
Wordpress 5.5.1

@sailorptah
Copy link

Hey there -- if this is still a problem, can you share a link to the website? Thanks!

@hyetou
Copy link
Author

hyetou commented Feb 8, 2021

Hey sure. After updates it's acting a bit different. Now the 'Next webcomic' and 'Previous webcomic' options work fine, but the option I want, 'Nothing', still does not work. It still causes the comic to link to itself, essentially refreshing the page when you click on the comic.

The site is https://www.giantsteeth.com

@Mihari
Copy link

Mihari commented Feb 9, 2021

Hey sure. After updates it's acting a bit different. Now the 'Next webcomic' and 'Previous webcomic' options work fine, but the option I want, 'Nothing', still does not work. It still causes the comic to link to itself, essentially refreshing the page when you click on the comic.

Sadly there is no way to remove the linking of the comic image short of a theme edit. The 'Nothing' option linking to itself is working as intended.

@sailorptah
Copy link

...wow, that's a really non-intuitive meaning for "Nothing."

Honestly, I would recommend using "Next webcomic"! That makes it a lot easier for readers to go through the archive, if they can just click anywhere on the comic image to move forward, rather than scrolling around to the little "Next" button image every time.

But if you really want to nix the link completely, that's the kind of thing I would do with the Real-Time Find and Replace plugin:

https://wordpress.org/plugins/real-time-find-and-replace/

Take a chunk of the source code that specifically identifies the webcomic image link, like this:

<div class="webcomic-image"><a href=

And replace the link part of the code with something nonfunctional, like this:

<div class="webcomic-image"><a data-disabled=

@hyetou
Copy link
Author

hyetou commented Feb 10, 2021

Many thanks for the help. I will take your advice, sailorptah, and have the image link to the next comic. I am happy that's working now.

@hyetou hyetou closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants