-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving up and down via shortcuts does not work in Firefox #176
Comments
Hmm, have you removed sorting from the project? When sorting is enabled,
task movement doesn't work.
For me task movement works in firefox
…On Fri, Apr 2, 2021 at 11:20 PM Matej Drobnič ***@***.***> wrote:
When attempting to move task up or down via Shift + Up/Down/j/k, task will
just blink in place, but will not move.
This is with Firefox 87.0 and todoist shortcuts 128.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#176>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFQKTNKCQNSNTSSKJJSHDTG2QTPANCNFSM42J3NKYA>
.
|
I can move tasks with mouse with no problems, so it's not the sorting. |
Are there any logs or anything else I can give you to help sort out the issue? |
If you download the extension code, and then set `DEBUG` to true here -
https://github.com/mgsloan/todoist-shortcuts/blob/master/src/todoist-shortcuts.js#L5
- then load the modified extension you will get a lot more logs. Not sure
if they will help diagnose, but they might!
It might not be necessary to enable the DEBUG logging. By default it will
still log errors, so the normal logs in developer tools might also be
useful.
…On Thu, Apr 8, 2021 at 3:25 AM Matej Drobnič ***@***.***> wrote:
Are there any logs or anything else I can give you to help sort out the
issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFQKWIWXTLCZ26OMHUWMTTHVZBFANCNFSM42J3NKYA>
.
|
Huh it seems to work now. Maybe it was an update from Todoist that messed up something before. Thanks for your help. |
This is still happening, but only in one project (can't find anything different in that project). Here is the debug log of me trying to move a task up with Shift + K:
EDIT: Logging out and back in fixed it. Can you get anything from above logs? EDIT2: Broken again. it seems to happen intermittently. |
Same issue - in Inbox w/ no sort enabled in chrome. none of the move lines work. Works with edge for some reason. |
Curious! The only browsers available to me are chrome and firefox, so I
can't straightforwardly work on this. Would accept patches fixing it
though, naturally!
…On Sat, Jul 10, 2021 at 8:11 AM GaryFurash ***@***.***> wrote:
Same issue - in Inbox w/ no sort enabled in chrome. none of the move lines
work. Works with edge for some reason.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFQKX5655O4EKZNCDMUPTTXBIIJANCNFSM42J3NKYA>
.
|
Well, I'm having issue in Firefox and @GaryFurash has an issue in Chrome, so I don't think this is an issue ;) Any chance you could make a branch with more logging enabled? That way I can install this and give you more logs on what is going on. |
True!
To get more logs you can change line 5 from `const DEBUG = false;` to
`const DEBUG = true;`
…-Michael
On Sun, Jul 25, 2021 at 12:31 AM Matej Drobnič ***@***.***> wrote:
The only browsers available to me are chrome and firefox, so I can't
straightforwardly work on this.
Well, I'm having issue in Firefox and @GaryFurash
<https://github.com/GaryFurash> has an issue in Chrome, so I don't think
this is an issue ;)
Any chance you could make a branch with more logging enabled? That way I
can install this and give you more logs on what is going on.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFQKVB3XG4JZE76RXEG7TTZOVUDANCNFSM42J3NKYA>
.
|
I've given you debug logs above. Or do you want me to retry this with newer builds (maybe you added more logging statements?)? |
Sorry, since I have no idea how to reproduce the bug, I can't really work on fixing it. |
Right, but we can reproduce it for you and give you all the necessary data to fix it. |
@mgsloan I've been trying to debug it and the issue appears to be in the Changing offset method to the following code fixes the shifting issue:
however, this change causes different issues (just moving up or down with j and k causes page to randomly scroll around). Do you have any idea what could cause the offset method to break? I can try inserting extra debug statements. |
Fix will be in version 142! Thanks matejdro! I can now reproduce this issue. The problem happens when there are enough tasks in a project to allow scrolling, and the window is scrolled down. I've kept the "put task in view" code using the old implementation of offset, and used matejdro's offset code for task movement. |
Thanks to [matejdro][] for identifying that client offsets work better for task movement in Firefox. [matejdro]: https://github.com/matejdro
That's amazing, thanks a lot. |
When attempting to move task up or down via Shift + Up/Down/j/k, task will just blink in place, but will not move.
This is with Firefox 87.0 and todoist shortcuts 128.
The text was updated successfully, but these errors were encountered: