Fix static typing issue & turn on mypy+pyright in adodbapi #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Jun 4, 2024
| @@ -461,20 +465,25 @@ def convert_to_python(variant, func): # convert DB value into Python value | |||
| return func(variant) # call the appropriate conversion function | |||
|
|
|||
|
|
|||
| class MultiMap(dict): # builds a dictionary from {(sequence,of,keys) : function} | |||
| """A dictionary of ado.type : function -- but you can set multiple items by passing a sequence of keys""" | |||
| class MultiMap(Dict[int, Callable[[object], object]]): | |||
There was a problem hiding this comment.
The typing issue here was that dict leads to partially Any type. Since this is a very small and simple class, I completely typed it.
Avasam
commented
Jun 4, 2024
| def __init__(self, aDict): | ||
| for k, v in list(aDict.items()): | ||
| def __init__(self, aDict: Mapping[Iterable[int] | int, Callable[[object], object]]): | ||
| for k, v in aDict.items(): |
There was a problem hiding this comment.
ItemsView (or in the case of a dict, dict_items) is already iterable. coercing to a list was redundant.
Avasam
force-pushed
the
adodbapi-fix-static-typing-issue
branch
from
ad5f536
to
fd5cc25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards a typed API.