Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centerline.py crashes with 3D coordinates #1

Closed
AsgerPetersen opened this issue Sep 13, 2014 · 4 comments
Closed

centerline.py crashes with 3D coordinates #1

AsgerPetersen opened this issue Sep 13, 2014 · 4 comments

Comments

@AsgerPetersen
Copy link

I had to change https://github.com/mharnold/spiderosm/blob/master/centerline.py#L44 into
points = [tuple(l[:2]) for l in part]
to trash Z ordinate. Otherwise the code crashes in a lot of places.

This might not be the right place to actually make sure geometries are 2D, but it worked for me :-)

@mharnold
Copy link
Owner

OK. Thanks! I will update the code.

By the way, I am thrilled that you are giving spiderosm a try. Please
let me now how it goes!

Cheers,
Michael
Berkeley Mismatched Street Names Map http://names.mhaprojects.com

On Sat, Sep 13, 2014 at 2:08 PM, Asger Skovbo Petersen <
notifications@github.com> wrote:

I had to change
https://github.com/mharnold/spiderosm/blob/master/centerline.py#L44 into
points = [tuple(l[:2]) for l in part]
to trash Z ordinate. Otherwise the code crashes in a lot of places.

This might not be the right place to actually make sure geometries are 2D,
but it worked for me :-)


Reply to this email directly or view it on GitHub
#1.

@AsgerPetersen
Copy link
Author

For the areas where I can get it to work. It works REALLY well. I believe this tool is going to improve the quality of OSM data (and possibly also the public data) in Denmark a lot.

@mharnold
Copy link
Owner

Great! Hopefully the unicode issues will not be too difficult to fix. A
work around might be to 'convert' strings to ascii by mapping non-ascii
characters to closest ascii equivalent. Maybe too ugly to contemplate?

Cheers,
Michael
Berkeley Mismatched Street Names Map http://names.mhaprojects.com

On Sat, Sep 13, 2014 at 3:36 PM, Asger Skovbo Petersen <
notifications@github.com> wrote:

For the areas where I can get it to work. It works REALLY well. I believe
this tool is going to improve the quality of OSM data (and possibly also
the public data) in Denmark a lot.


Reply to this email directly or view it on GitHub
#1 (comment).

@mharnold
Copy link
Owner

I've modified centerline.py to discard any z-coordinates in input (with a warning message.) This change has been pushed to the github repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants