Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing (or dropping) https support #176

Open
ryanblock opened this issue Sep 4, 2023 · 3 comments
Open

Changing (or dropping) https support #176

ryanblock opened this issue Sep 4, 2023 · 3 comments
Labels
question

Comments

@ryanblock
Copy link
Member

ryanblock commented Sep 4, 2023 •
edited

Currently, Dynalite supports https connections with an ssl option; you can pass it key, cert, and ca options, or Dynalite will read its own default keys.

Unfortunately, Dynalite's own keys have apparently expired, and with a major release coming up in the future this would be a good opportunity to alter this behavior.

With Sandbox (our other local AWS emulator), time and time again we've looked at adding https to our API Gateway emulation. Each time we arrive at the conclusion that it's way more trouble than it's worth (especially given the local dev context).

My preference would be to drop support entirely, but if folks do indeed make use of this feature, at very least I'd like to change support to a) you must supply a key, cert, and ca (or file paths to them), and b) we will not be offering any support for this feature.

Thoughts?
@reconbot
Copy link
Member

reconbot commented Sep 4, 2023

At the very least we should stop passing the options object into the https.createServer directly and either leave it with the keys only, or support passing options into both http servers. Eg, port as an option only works with ssl enabled today.

@ryanblock
Copy link
Member Author

That's legit, and worthy of a separate issue imo.

@ryanblock ryanblock mentioned this issue Sep 5, 2023
Closed
ryanblock added a commit that referenced this issue Sep 5, 2023
@ryanblock
Drop use of self-signed certs (which are now expired), fixes #176
3bd330d 
Add `--key`, `--cert`, `--ca` CLI flags, and `useSSLFilePaths` API option
Only require `http` or `https`, but not both
Update types
Fix `--port` + `--host` not being passed in `http` mode; fixes #178
@ryanblock
Copy link
Member Author

Will leave this PR open until tomorrow to get additional feedback, then move on. I'd love to try and have 4.0 out sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reconbot @ryanblock