Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image(node): upgrade node:9.4-alpine to node:12-alpine #26

Merged

Conversation

jjangga0214
Copy link
Contributor

@jjangga0214 jjangga0214 commented Dec 27, 2019

This has some benefits.

  1. Users will be able to use modern code without transpiling or configuring NODE_IMAGE.
  2. As the new image is just 12(not specifying minor version), a new feature(minor version up) and security patch(patch version up) will be automatically applied in the future, without any breaking change.
  3. This is LTS version. Therefore there will be long-term stable support and update, which makes sense for 12 to be a default version.
  4. In the code level, 12 is compatible with 9.4(https://node.green/). Thus the majority of users who've been using the default version(9.4) do not have to manually configure NODE_IMAGE even with the new default version.

This might close #24, but I'm not sure if other languages' default versions are be good to be changed.

Close mhausenblas#24

Signed-off-by: GIL B. Chan <bnbcmindnpass@gmail.com>
@mhausenblas
Copy link
Owner

Perfect, thank you @jjangga0214!

@mhausenblas mhausenblas merged commit 5cfb707 into mhausenblas:master Dec 27, 2019
@jjangga0214 jjangga0214 deleted the node/version/12-alpine/0 branch January 31, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is the default runtime not LTS?
2 participants