Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern Rust build fixes + Travis build #19

Merged
merged 21 commits into from
Apr 4, 2020
Merged

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Feb 10, 2020

So starting from the issues in #18, I fixed all the build issues I could find (both errors and warnings) and then got a Travis build up and running for both Ubuntu and OS X.

Notes:

  • https://travis-ci.org/mheese/rust-pkcs11 will need activating and the build badge urls swapped over. https://travis-ci.org/palfrey/rust-pkcs11 shows builds so far.
  • I wasn't able to get the build working with libsofthsm2 2.2 which is the default in Ubuntu Bionic, so there's an additional apt line in the build to pull in libsofthsm 2.4 from Disco. I don't quite know whether this is not meant to work, or if there's something I was missing in the testing.
  • In order to make the tests work, the Travis user needs to be (in Linux at least) in the softhsm group, which then needs the sudo/su hack to get the group membership properly picked up.

@palfrey palfrey requested a review from mheese February 10, 2020 23:14
@mheese
Copy link
Owner

mheese commented Feb 14, 2020

@palfrey awesome!! thanks! ... I will look into this on the weekend in my spare time

@palfrey
Copy link
Contributor Author

palfrey commented Feb 23, 2020

@mheese How's this getting on? Anything I can do to help?

@mheese
Copy link
Owner

mheese commented Apr 4, 2020

@palfrey dealing with all the PRs right now ... this one is critical tbh ... thanks again

I believe that libsofthsm2 2.2 is actually implementing an older PKCS11 version and that might not work 🤔

As an additional feature we should probably test several different PKCS11 versions.

Copy link
Owner

@mheese mheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@mheese mheese merged commit 383051d into mheese:master Apr 4, 2020
@palfrey palfrey deleted the build-errors branch April 4, 2020 19:18
@palfrey palfrey mentioned this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants