-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern Rust build fixes + Travis build #19
Conversation
@palfrey awesome!! thanks! ... I will look into this on the weekend in my spare time |
@mheese How's this getting on? Anything I can do to help? |
@palfrey dealing with all the PRs right now ... this one is critical tbh ... thanks again I believe that libsofthsm2 2.2 is actually implementing an older PKCS11 version and that might not work 🤔 As an additional feature we should probably test several different PKCS11 versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍
So starting from the issues in #18, I fixed all the build issues I could find (both errors and warnings) and then got a Travis build up and running for both Ubuntu and OS X.
Notes:
softhsm
group, which then needs the sudo/su hack to get the group membership properly picked up.