Don't be so greedy while looking for knife errors

Fixes false positive when there is a "Invalid gemspec" error
mheffner · Oct 17, 2011 · 245f8f5 · 245f8f5
1 parent 3a1d918
commit 245f8f5
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/littlechef/lib.py b/littlechef/lib.py
@@ -98,8 +98,7 @@ def _generate_metadata(path, cookbook_path, name):
                 ['knife', 'cookbook', 'metadata', '-o', cookbook_path, name],
                 stdout=subprocess.PIPE, stderr=subprocess.PIPE)
             resp, error = proc.communicate()
-            if (error or 'FATAL:' in resp or
-                'Generating metadata for' not in resp):
+            if ('FATAL:' in resp or 'Generating metadata for' not in resp):
                 msg = "Unkown error while generating metadata.json for "
                 msg += "{0}. Cookbook attributes may be out of date".format(
                     path)