Refactored upgly iteration to inject

mhennemeyer · Nov 5, 2008 · 3daa8be · 3daa8be
1 parent 09ef258
commit 3daa8be
Show file tree

Hide file tree

Showing 2 changed files with 359 additions and 5 deletions.
diff --git a/lib/existence_validated.rb b/lib/existence_validated.rb
@@ -1,18 +1,16 @@
 def existence_validated(assocs=[], options={})
   assocs = [assocs] unless assocs.respond_to?(:each)
-  hash ||= {}
-  assocs.each do |assoc|
+  assocs.inject({}) do |memo, assoc|
     unless options.has_key?(assoc) && options[assoc] == nil
       klass = assoc.to_s.camelize.constantize
       mock = options[assoc] || mock_model(klass)
       klass.should_receive(:exists?).any_number_of_times.and_return do |fk|
         fk ? true : false
       end
-      hash.update({
+      memo.update({
         assoc.to_s.concat("_id").to_sym => mock.id,
         assoc => mock
       })
-    end
+    end || {}
   end
-  hash
 end