Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent documentation for config validation #647

Closed
crondaemon opened this issue Oct 11, 2021 · 1 comment · Fixed by #672
Closed

Inconsistent documentation for config validation #647

crondaemon opened this issue Oct 11, 2021 · 1 comment · Fixed by #672

Comments

@crondaemon
Copy link
Contributor

Describe the bug
The documentation states

assert SidekiqUniqueJobs.validate_worker!(BadWorker.get_sidekiq_options)

in the minitest section. Hoever, the code is

raise InvalidWorker, lock_config unless lock_config.errors.empty?

this would require assert_nothing_raised or similar to be used.

Expected behavior
A failing test should gently say the test is not passed.

Current behavior
The test crashes.

@mhenrixon
Copy link
Owner

PRs greatly appreciated. I don't use test unit and friends

crondaemon added a commit to crondaemon/sidekiq-unique-jobs that referenced this issue Dec 26, 2021
crondaemon added a commit to crondaemon/sidekiq-unique-jobs that referenced this issue Dec 26, 2021
crondaemon added a commit to crondaemon/sidekiq-unique-jobs that referenced this issue Dec 26, 2021
mhenrixon pushed a commit that referenced this issue Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants