Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: fix minitest assertion. #672

Merged
merged 1 commit into from
Dec 30, 2021
Merged

readme: fix minitest assertion. #672

merged 1 commit into from
Dec 30, 2021

Conversation

crondaemon
Copy link
Contributor

Fix: #647.

mhenrixon
mhenrixon approved these changes Dec 30, 2021
View reviewed changes
Copy link
Owner

@mhenrixon mhenrixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the PR

@crondaemon
Copy link
Contributor Author

The ci failed on ruby3. However this is not related to the change I made on resume. Is your master failing?

@mhenrixon mhenrixon merged commit 95cc57e into mhenrixon:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhenrixon mhenrixon mhenrixon approved these changes

Assignees

@crondaemon crondaemon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent documentation for config validation
2 participants
@crondaemon @mhenrixon