Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gemspec: thor #465

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Update gemspec: thor #465

merged 2 commits into from
Mar 18, 2020

Conversation

masawo
Copy link
Contributor

@masawo masawo commented Jan 7, 2020

Now, the thor gem is version 1.0.1.

On my repository, using sidekiq-unique-jobs, I tried to update thor gem, but its version stayed the same.

To resolve this, I modified .gemspec file with reference to an other repository below:
https://github.com/rails/jquery-rails/blob/master/jquery-rails.gemspec#L19

@mhenrixon mhenrixon self-assigned this Jan 7, 2020
@jpalumickas
Copy link

Any updates on this one?

Copy link
Owner

@mhenrixon mhenrixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for the patience! This one completely dropped from my radar...

Hopefully, the new Github iOS app will help prevent future such problems.

@mhenrixon mhenrixon merged commit 40db285 into mhenrixon:master Mar 18, 2020
@jpalumickas
Copy link

Thank you ! 🎉

@masawo masawo deleted the gemspec-thor branch March 24, 2020 11:41
replaid added a commit to RosieApp/sidekiq-unique-jobs that referenced this pull request Jun 19, 2020
mhenrixon pushed a commit that referenced this pull request Jun 23, 2020
JureCindro added a commit to BookingSync/sidekiq-unique-jobs that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants