Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Issue: Incomplete carry-through of --url_prefix in flower 4.1 (development version) #39

Closed
npinger opened this issue Dec 6, 2012 · 1 comment

Comments

@npinger
Copy link

npinger commented Dec 6, 2012

Setup:

django-celery 3.0.11
flower 4.1 (development version as of 12/6/2012)

Issue

I was trying to get OAuth working properly running:

$ python manage.py celery flower --url_prefix=flower --address=example.com  --auth=name@example.com

Using the setup described in this issue: #13

When I tried to go to http://example.com/flower, I was properly redirected to a google OAuth page and signed in. After sign in (and whenever I tried to visit any page http://example.com/flower/.* thereafter), I was first redirected to:

http://example.com/login

Unfortunately, the http://example.com/login automatically redirects to http://example.com when a user is logged in to example.com (due to the settings on example.com).

As a result, any attempt to view flower redirects to http://example.com.

Not sure, but it seems that when --url_prefix=flower is defined, oauth logins should redirect through:

http://example.com/flower/login instead of http://example.com/login

NOTE: The same issue appears to happen in flower 0.4.0 without --url_prefix. With the command:

$ python manage.py celery flower --port=5555 --address=example.com  --auth=name@example.com

OAuth logins seem to pass through:

http://example.com/login instead of the expected http://example.com:5555/login

This leads to a similar redirect path.

Thanks for looking into this. Appreciate any feedback or fixes you have.

mher added a commit that referenced this issue Dec 9, 2012
@mher
Copy link
Owner

mher commented Dec 9, 2012

Thanks for reporting! Please try the latest version from the master.

@mher mher closed this as completed Dec 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants