-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that we don't pipe stdin when starting a job #250
Conversation
Starting with version 13, ripgrep always stats stdin and if it's not a TTY it uses it to read data. Unfortunately, Neovim always attaches a pipe to stdin by default and that leads to ripgrep reading nothing and it essentially breaks vim-grepper when targeting a recent version of ripgrep. (see neovim/neovim#14812 for more info) This was fixed in nvim by adding an option to jobstart to not pipe stdin (see neovim/neovim#14812). So we use this here which I verified fixes search through rg. Note that I'm not 100% sure how to gate this. It was technically added as a commit to neovim after 0.5 shipped so I imagine it will technically be released in 0.5.1. But it should also be harmless to only gate this to `nvim` since the options are a dictionary and old versions of neovim will just ignore that `stdin` key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed to work with updated Neovim master.
Thanks!
Great, thanks again. |
I have merge rights, just one question, will |
Yes it will. I’m running the nightly 0.6 version and it works fine. |
Now that mhinz/vim-grepper#250 landed
Now that mhinz/vim-grepper#250 landed
Now that mhinz/vim-grepper#250 landed
Now that mhinz/vim-grepper#250 landed
Starting with version 13, ripgrep always stats stdin and if it's not a TTY it uses it to read data. Unfortunately, Neovim always attaches a pipe to stdin by default and that leads to ripgrep reading nothing and it essentially breaks vim-grepper when targeting a recent version of ripgrep.
(see BurntSushi/ripgrep#1892 for more info)
This was fixed in nvim by adding an option to jobstart to not pipe stdin (see neovim/neovim#14812). So we use this here which I verified fixes search through rg.
Note that I'm not 100% sure how to gate this. It was technically added as a commit to neovim after 0.5 shipped so I imagine it will technically be released in 0.5.1. But it should also be harmless to only gate this to
nvim
since the options are a dictionary and old versions of neovim will just ignore thatstdin
key.This fixes #244