Make sure that we don't pipe stdin when starting a job #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with version 13, ripgrep always stats stdin and if it's not a TTY it uses it to read data. Unfortunately, Neovim always attaches a pipe to stdin by default and that leads to ripgrep reading nothing and it essentially breaks vim-grepper when targeting a recent version of ripgrep. (see neovim/neovim#14812 for more info) This was fixed in nvim by adding an option to jobstart to not pipe stdin (see neovim/neovim#14812). So we use this here which I verified fixes search through rg. Note that I'm not 100% sure how to gate this. It was technically added as a commit to neovim after 0.5 shipped so I imagine it will technically be released in 0.5.1. But it should also be harmless to only gate this to `nvim` since the options are a dictionary and old versions of neovim will just ignore that `stdin` key.
blueyed
approved these changes
Aug 19, 2021
blueyed
approved these changes
Aug 20, 2021
|
Great, thanks again. |
|
I have merge rights, just one question, will |
|
Yes it will. I’m running the nightly 0.6 version and it works fine. |
ddeville
added a commit
to ddeville/scripts
that referenced
this pull request
Aug 20, 2021
Now that mhinz/vim-grepper#250 landed
ddeville
added a commit
to ddeville/scripts
that referenced
this pull request
Jun 4, 2023
Now that mhinz/vim-grepper#250 landed
ddeville
added a commit
to ddeville/scripts
that referenced
this pull request
Jun 4, 2023
Now that mhinz/vim-grepper#250 landed
ddeville
added a commit
to ddeville/scripts
that referenced
this pull request
Jun 4, 2023
Now that mhinz/vim-grepper#250 landed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version 13, ripgrep always stats stdin and if it's not a TTY it uses it to read data. Unfortunately, Neovim always attaches a pipe to stdin by default and that leads to ripgrep reading nothing and it essentially breaks vim-grepper when targeting a recent version of ripgrep.
(see BurntSushi/ripgrep#1892 for more info)
This was fixed in nvim by adding an option to jobstart to not pipe stdin (see neovim/neovim#14812). So we use this here which I verified fixes search through rg.
Note that I'm not 100% sure how to gate this. It was technically added as a commit to neovim after 0.5 shipped so I imagine it will technically be released in 0.5.1. But it should also be harmless to only gate this to
nvimsince the options are a dictionary and old versions of neovim will just ignore thatstdinkey.This fixes #244