Use shellescape() instead of fnameescape() to escape file names

[fritzophrenic]

I had to change fnameescape() to shellescape() to avoid errors when editing files in a path containing spaces in Windows 7.

Something like this needs to be done for all supported VCS types:

let sh_sav = &shellslash
if has('win32')
  set noshellslash
endif
let diff = system('hg diff --nodates -U0 -- '. shellescape(a:path) .' | findstr "^@@ "')
let &shellslash = sh_sav

fnameescape() is meant for arguments to Vim functions or commands, and shellescape() is meant for arguments to external commands. The system() call is the latter.

[mhinz]

Hmm, I knew of the difference but somehow assumend that, because Vim's system() is just a wrapper to system-specific functions, it would be fine.

(Yes, ':h system' stresses that..)

Thanks!

[mhinz]

Do I have to set noshellslash for every casewhen I use shellescape() on win32?

[fritzophrenic]

Do I have to set noshellslash for every casewhen I use shellescape() on win32?

:help 'shellslash' says:

This is
useful when a Unix-like shell is used instead of command.com or
cmd.exe.  Backward slashes can still be typed, but they are changed to
forward slashes by Vim.

But many people use it even with cmd.exe because it lets you use forward slashes within Vim easier, and most (but not all) Windows programs in cmd.exe will work with both forward and backwards slashes.

It would probably be best, if you also test the value of 'shell' to see whether it actually is still set to start with "command" or "cmd"; shellslash can remain set if a Unix-like shell is actually being used. The reason for resetting 'shellslash' if cmd.exe or similar is in use, is that shellescape() assumes a Unix-like shell if shellslash is set.

[fritzophrenic]

I added a note to 1de08cb, I got it working with a minor modification. Thanks for fixing this!