-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clj-time #65
Comments
Agreed. In all the places where duration is required clj-gatling should use
Java 8 date objects by default. I also like to keep backwards
compatibility. So clj-time should be kept as option.
This is definitely a thing that should be fixed. I can take a look when I
have time. Pull requests are also always welcome!
…On Fri, May 21, 2021, 18:45 Andrea Crotti ***@***.***> wrote:
I noticed that this project requires and uses clj-time, which is
deprecated in favour of the java API from version 8 onwards.
https://github.com/clj-time/clj-time
It would be great to just require the java API object at least in the
scenario configuration (for the duration) instead of a joda-time object.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#65>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXAUZVNEKKOVMGME2TPN3TOZ525ANCNFSM45JMV7BQ>
.
|
If you leave clj-time as an option then doesn't it mean still requiring the dependency anyway? From the user point of view updating would be just to change maybe a few clj-time date/times to the equivalent java 8 objects, and only if somehow you are not on java 8 yet it would be an issue (and it was released 7 years so it's been a while). |
You are right. This could be implemented in a way that both Java 8 dates
and clj-time are accepted and by default next version of clj-gatling does
not have clj-time as a dependency. This way old users don't have to change
their code. Only thing they have to do is to add explicit clj-time
dependency
…On Mon, May 24, 2021, 13:55 Andrea Crotti ***@***.***> wrote:
If you leave clj-time as an option then doesn't it mean still requiring
the dependency anyway?
I think it should be fine if newer versions only take java 8+ date/time
objects, keeping clj-time around would maybe defeat the purpose a bit imho.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXAU7OVJRT7B24BN52F5LTPIWBTANCNFSM45JMV7BQ>
.
|
This turned out to be trickier than I thought. I now have a PR ready that I am going to merge soon. #69 |
clj-gatling |
Nice thanks! |
I noticed that this project requires and uses clj-time, which is deprecated in favour of the java API from version 8 onwards.
https://github.com/clj-time/clj-time
It would be great to just require the java API object at least in the scenario configuration (for the duration) instead of a joda-time object.
The text was updated successfully, but these errors were encountered: