Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zip: support non-utf8 filenames #149

Closed
wants to merge 1 commit into from
Closed

zip: support non-utf8 filenames #149

wants to merge 1 commit into from

Conversation

zxdvd
Copy link

@zxdvd zxdvd commented Mar 1, 2019

For issue #147 , add an option to specify the encoding.

xiaogu-space
xiaogu-space approved these changes Sep 4, 2020
View reviewed changes
Copy link

@xiaogu-space xiaogu-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is correct

carlleton
carlleton approved these changes Sep 4, 2020
View reviewed changes
Copy link

@carlleton carlleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok

@mholt
Copy link
Owner

mholt commented Jan 2, 2022

Thanks for this, might fix a number of open issues, and I will see if I can incorporate it into #302. I need to find a file to test with.

mholt added a commit that referenced this pull request Jan 2, 2022
@mholt
zip: Decode non-UTF-8 encoded filenames (by @zxdvd)
1f30051 
Closes #147
Supersedes #149
@mholt
Copy link
Owner

mholt commented Jan 2, 2022

Thanks all for contributing and reviewing this. Sorry I didn't get around to this for years, but I have implemented it in #302 which completely replaces the current code base, and given credit to @zxdvd in the code and in the commit. Really appreciate it.

@mholt mholt closed this Jan 2, 2022
mholt added a commit that referenced this pull request Jan 4, 2022
@mholt
v4 rewrite: All new design, core types, and stream-oriented interfaces (
10c5080 
#302)

* Initial commit of v4 rewrite; core types, methods

* Correct file permissions

* Use xz lib with standard license (close #259)

* zip: Decode non-UTF-8 encoded filenames (by @zxdvd)

Closes #147
Supersedes #149

* Improve ArchiveFS; fix directory traversal

* Add placeholder command for now

Not sure when I'll get around to reimplementing this for v4.

* ci: Require Go 1.17

* Swap params for Inserter interface

More aesthetically pleasing when enumerating files

* Add readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aisensiy aisensiy aisensiy approved these changes

@xiaogu-space xiaogu-space xiaogu-space approved these changes

@carlleton carlleton carlleton approved these changes

@DeJoker DeJoker DeJoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zxdvd @mholt @aisensiy @xiaogu-space @carlleton @DeJoker