Fix 'NonHierarchicalClustering' object has no attribute 'ranges' ch5 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In chapter 5 method compute_distance_matrix_instances the attribute self.ranges is accessed but this is unset. The cause is that ranges above is set as variable within the scope of the current method but since this is not the constructor of the class it does not actually set self.ranges. This in turn causes the subsequent access to result in an AttributeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chapter 5 method
compute_distance_matrix_instancesthe attributeself.rangesis accessed but this is unset. The cause is that
rangesabove is set as variablewithin the scope of the current method but since this is not the constructor of
the class it does not actually set
self.ranges. This in turn causes thesubsequent access to result in an
AttributeError.This pull request resolves the aforementioned issues above.