Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix broken runner, as process input does not work as expected #81

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

fvilpoix
Copy link
Contributor

The full update I've done for SF4 compatibility relied on Process inputs, which seem to not be the command's arguments. In fact, I don't see what's their usage...

I miss the point because I relied on phpunit tests, which mock the full process system.

I changed the process setup to give it the full command line including args through ENV vars.

AND I tested that in normal usage (outside tests), mediainfo are fetched without error, without Symfony 2, 3 and 4.

This time, it should be ok :D

@mhor mhor added the bug label Dec 21, 2017
@mhor mhor merged commit 8182c69 into mhor:master Dec 21, 2017
@mhor
Copy link
Owner

mhor commented Dec 21, 2017

Thanks for the fix 👍 ! Release as 4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants