Skip to content
This repository has been archived by the owner on Nov 28, 2019. It is now read-only.

Make git-prompt.sh a manual install? #213

Closed
mhulse opened this issue Oct 9, 2019 · 4 comments
Closed

Make git-prompt.sh a manual install? #213

mhulse opened this issue Oct 9, 2019 · 4 comments

Comments

@mhulse
Copy link
Owner

mhulse commented Oct 9, 2019

Or, have bash function to download and install the latest version?

https://github.com/git/git/blob/master/contrib/completion/git-prompt.sh

I currently have a copy in the .scripts directory:

https://github.com/mhulse/dotfizzles/blob/389a2423004e86bcf3f8ccf3cc84d6363831f73e/.scripts/git-prompt.sh

@mhulse
Copy link
Owner Author

mhulse commented Oct 9, 2019

Use the work in #214 to install this script.

@mhulse
Copy link
Owner Author

mhulse commented Oct 10, 2019

This actually comes bundled in Homebrew’s installation of git:

https://stackoverflow.com/a/12871094/922323

I am changing my prompt script to use this:

$ source "`brew --prefix git`/etc/bash_completion.d/git-prompt.sh"

So, I will document that people should run the dependency installation instructions (found in WIKI) before using dotfizzles.

Now that Homebrew is managing git, this script will update itself when git updates. This is much better than manually managing it.

mhulse pushed a commit that referenced this issue Oct 23, 2019
I did not realize this before, but `git-prompt` comes with `git`, so I’m making that a hard dependency (thus, the removal of the conditional check) and documenting this dependency in the wiki:

https://github.com/mhulse/dotfizzles/wiki/Dependencies

Fixes #213
@mhulse
Copy link
Owner Author

mhulse commented Oct 24, 2019

Added to house cleaning branch.

Git dep is now documented in wiki:

https://github.com/mhulse/dotfizzles/wiki/Dependencies

Closing.

@mhulse mhulse closed this as completed Oct 24, 2019
mhulse pushed a commit that referenced this issue Oct 31, 2019
I did not realize this before, but `git-prompt` comes with `git`, so I’m making that a hard dependency (thus, the removal of the conditional check) and documenting this dependency in the wiki:

https://github.com/mhulse/dotfizzles/wiki/Dependencies

Fixes #213
@mhulse
Copy link
Owner Author

mhulse commented Nov 19, 2019

$ source "`brew --prefix git`/etc/bash_completion.d/git-prompt.sh"

THE ABOVE WAS SLOOOOOWWWWWWWWWWWWWWW!

Ended up switching to:

source "/usr/local/opt/git/etc/bash_completion.d/git-prompt.sh"

Still seems generic enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant