New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of indirect object notation (CPAN PRC) #3

Merged
merged 1 commit into from Apr 8, 2017

Conversation

Projects
None yet
3 participants
@s-nez
Contributor

s-nez commented Jan 30, 2017

This change replaces uses of indirect object notation, changing

new Foo @args

to

Foo->new(@args)
@plicease

This comment has been minimized.

Show comment
Hide comment
@plicease

plicease Jan 30, 2017

Collaborator

I agree with this change. For some context, here is a discussion of the challenges for using indirect object notation:

http://modernperlbooks.com/mt/2009/08/the-problems-with-indirect-object-notation.html

Collaborator

plicease commented Jan 30, 2017

I agree with this change. For some context, here is a discussion of the challenges for using indirect object notation:

http://modernperlbooks.com/mt/2009/08/the-problems-with-indirect-object-notation.html

@mhx

This comment has been minimized.

Show comment
Hide comment
@mhx

mhx Apr 8, 2017

Owner

Looks good to me, thanks! 👍

Owner

mhx commented Apr 8, 2017

Looks good to me, thanks! 👍

@mhx mhx merged commit 493a81c into mhx:master Apr 8, 2017

@s-nez s-nez deleted the s-nez:remove_indirect_constructors branch Apr 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment