Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear compile-time jemalloc definition #17

Closed
RarogCmex opened this issue Dec 3, 2020 · 4 comments
Closed

Clear compile-time jemalloc definition #17

RarogCmex opened this issue Dec 3, 2020 · 4 comments

Comments

@RarogCmex
Copy link
Contributor

Good daytime!
I'm Gentoo GURU project (semi-official) maintainer. I've ported dwarfs to Gentoo.
From dependency list dwarfs requires libjemalloc-dev, but It was succesfully build without ones? Does jemalloc really need?
Could you set up clear compile-time cmake option (something like current WITH_LUA) to set up that jemalloc really used?

@RarogCmex
Copy link
Contributor Author

In Gentoo there are USE flags, that are able to switch various configure-time and compile-time things. USE flags are used to for flexibility: you may build system your own

@mhx
Copy link
Owner

mhx commented Dec 3, 2020

Hi @RarogCmex!

Nice, happy to hear that, I'm using Gentoo as my main distribution for more than 15 years. :)

With regards to libjemalloc-dev, that's a requirement I pulled in via folly. However, dwarfs only uses a small subset of the folly library, and it's entirely possible that this dependency is unnecessary. I'm not consciously using jemalloc anywhere, so it's quite possible that it's not needed. I've just checked and I've actually done all my testing on a Gentoo box that doesn't have jemalloc installed, so I'm pretty certain it's not needed.

The Lua support currently requires luabind, which I think is no longer in portage as it's basically unsupported. I've got my own ebuild for it, but long term I'd rather drop the dependency. So for now it's probably best to not add a USE flag for Lua support.

@mhx
Copy link
Owner

mhx commented Dec 3, 2020

I've also just confirmed on a Ubuntu VM that the jemalloc dependency isn't needed.

@RarogCmex
Copy link
Contributor Author

@mhx Thank you for answer, I'll remove that dependency.

gentoo-bot pushed a commit to gentoo/guru that referenced this issue Dec 4, 2020
Removed unused jemalloc dependency and USE, see:
See mhx/dwarfs#17

Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Denis Reva <denis7774@gmail.com>
maxirmx added a commit to tamatebako/dwarfs-2 that referenced this issue Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants