Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ricepp tries to add nonexistent googletest directory even if -DPREFER_SYSTEM_GTEST=ON is set #194

Closed
RarogCmex opened this issue Feb 12, 2024 · 2 comments
Closed

Ricepp tries to add nonexistent googletest directory even if -DPREFER_SYSTEM_GTEST=ON is set #194

RarogCmex opened this issue Feb 12, 2024 · 2 comments
Assignees
@mhx
Labels
bug Something isn't working
Milestone
v0.9.4

Comments

@RarogCmex
Copy link
Contributor

I'm trying to pass tests in gentoo ebuild. From log:

-- [ricepp] adding CPU target: ricepp_fallback
CMake Error at ricepp/CMakeLists.txt:161 (add_subdirectory):
  add_subdirectory given source
  "/var/tmp/portage/sys-fs/dwarfs-0.9.3/work/dwarfs-0.9.3/_deps/googletest-src"
  which is not an existing directory.

The build log:
build.log
This reproduces only when tests is on:
USE='test' ebuild dwarfs-0.9.3.ebuild manifest clean test
@mhx
Copy link
Owner

mhx commented Feb 12, 2024

Yes, I can confirm this. I'll prepare a fix for the next release, hopefully later today.

@mhx mhx self-assigned this Feb 12, 2024
@mhx mhx added the bug Something isn't working label Feb 12, 2024
@mhx mhx added this to the v0.9.4 milestone Feb 12, 2024
mhx added a commit that referenced this issue Feb 12, 2024
@mhx
fix: ensure gtest target exists so ricepp won't fetch it (fixes gh #194)
47b1ee4
mhx added a commit that referenced this issue Feb 12, 2024
@mhx
fix: ensure gtest target exists so ricepp won't fetch it (fixes gh #194)
b2bd49e
mhx added a commit that referenced this issue Feb 12, 2024
@mhx
fix: ensure gtest target exists so ricepp won't fetch it (fixes gh #194)
f713084
@mhx
Copy link
Owner

mhx commented Feb 12, 2024

Should be fixed in v0.9.4.

@mhx mhx closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhx mhx

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.9.4
Development

No branches or pull requests
2 participants
@mhx @RarogCmex