Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbundling #46

Closed
Alessandro-Barbieri opened this issue May 1, 2021 · 10 comments
Closed

unbundling #46

Alessandro-Barbieri opened this issue May 1, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@Alessandro-Barbieri
Copy link

Please provide a way to unbundle folly, fbthrift, fsst and parallel-hashmap. I'm packaging this for gentoo and I'll really appreciate

@mhx
Copy link
Owner

mhx commented May 1, 2021

Hi @Alessandro-Barbieri,

Are you aware of https://gpo.zugaina.org/Overlays/guru/sys-fs/dwarfs? This is maintained by @RarogCmex.

What's your plan for the dependencies? Are you planning to maintain folly, fbthrift, etc as separate ebuilds?

I can definitely support external versions for all these libraries, similar to zstd & xxHash. Is that what you're looking for?

@mhx mhx added the enhancement New feature or request label May 1, 2021
@RarogCmex
Copy link
Contributor

Good daytime all!
At this moment I experienced some…well, adventures with russian military enlistment office, so I can't make that ebuilds this time. I even think about the resign my maintainership.
However, @Alessandro-Barbieri , if you do that, I'll send you my applauses :)

vlcsnap-2021-05-01-18h58m45s718

@Alessandro-Barbieri
Copy link
Author

I've already made all the ebuilds for the dependencies except for parallel-hashmap (soon I'll make one for that)

@Alessandro-Barbieri
Copy link
Author

Alessandro-Barbieri commented May 2, 2021

Now on guru there are

  • folly (with exception_tracer)
  • fbthrift
  • wangle
  • parallel_hashmap
  • fizz

@Alessandro-Barbieri
Copy link
Author

Alessandro-Barbieri commented Jul 10, 2021

I can definitely support external versions for all these libraries, similar to zstd & xxHash. Is that what you're looking for?

Yes

@RarogCmex
Copy link
Contributor

Good day everyone!
What is current status of unbundling in 0.6.1?
@Alessandro-Barbieri Could you update your patchset?

@mhx
Copy link
Owner

mhx commented Jun 18, 2022

I've just pushed an unbundling branch. This has new options PREFER_SYSTEM_PARALLEL_HASHMAP and PREFER_SYSTEM_FOLLY.

There's no PREFER_SYSTEM_FBTHRIFT yet, because I'd like to get the other stuff working before tackling thrift. The current issues are that dev-cpp/folly is too old for thrift to build. I just made my own folly ebuild for 2022.06.06.00 and with that, I can compile dwarfs. However, linking currently fails because folly's folly-config.cmake introduces a linker dependency on gflags_shared.

Please feel free to investigate further based on this branch.

@Alessandro-Barbieri
Copy link
Author

Could you share that ebuild?

@mhx
Copy link
Owner

mhx commented Jul 4, 2022

https://gist.github.com/mhx/fc93326bd7e5c91cf7fffcdf68bef9b6

(TBH, I think I just renamed the file that's in the package index, so "my own ebuild" was probably a bit exaggerated.)

@mhx
Copy link
Owner

mhx commented Oct 29, 2022

Is there anything left to do here? I'm closing this for now, please feel free to reopen if this isn't done yet.

@mhx mhx closed this as completed Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants