Skip to content

Commit

Permalink
fix(react): update storybook/cypress tests with tab context theme cha…
Browse files Browse the repository at this point in the history
…nges

Update storybook/cypress tests with tab context theme changes
  • Loading branch information
GCHQ-Developer-530 authored and GCHQ-Developer-299 committed Sep 27, 2024
1 parent 73555a2 commit 5a9ed1c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 74 deletions.
4 changes: 2 additions & 2 deletions packages/react/src/component-tests/IcTabs/IcTabsTestData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export const ResponsiveTabs = (): ReactElement => (

export const ResponsiveLightTextTabs = (): ReactElement => (
<div style={{ margin: "2rem" }}>
<IcTabContext appearance="light">
<IcTabContext theme="dark">
<IcTabGroup label="Example tab group">
<IcTab>One</IcTab>
<IcTab>Two</IcTab>
Expand Down Expand Up @@ -212,7 +212,7 @@ export const ResponsiveLightTextTabs = (): ReactElement => (

export const LightTabs = (): ReactElement => (
<div style={{ margin: "2rem" }}>
<IcTabContext appearance="light">
<IcTabContext theme="dark">
<IcTabGroup label="Example tab group">
<IcTab>Ingredients</IcTab>
<IcTab>Method</IcTab>
Expand Down
84 changes: 12 additions & 72 deletions packages/react/src/stories/ic-tabs.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -201,36 +201,6 @@ export const ControlledTabsExample = () => {
</Story>
</Canvas>

### Light text

<Canvas>
<Story name="Light text" parameters={{ backgrounds: { default: "dark" } }}>
<IcTabContext appearance="light">
<IcTabGroup label="Example tab group">
<IcTab>One</IcTab>
<IcTab>Two</IcTab>
<IcTab>
Three
<svg
slot="icon"
xmlns="http://www.w3.org/2000/svg"
height="24px"
viewBox="0 0 24 24"
width="24px"
fill="#000000"
>
<path d="M0 0h24v24H0V0z" fill="none" />
<path d="M9 16.2L4.8 12l-1.4 1.4L9 19 21 7l-1.4-1.4L9 16.2z" />
</svg>
</IcTab>
</IcTabGroup>
<IcTabPanel>Tab One</IcTabPanel>
<IcTabPanel>Tab Two</IcTabPanel>
<IcTabPanel>Tab Three</IcTabPanel>
</IcTabContext>
</Story>
</Canvas>

### Responsive

<Canvas>
Expand Down Expand Up @@ -266,46 +236,15 @@ export const ControlledTabsExample = () => {
</Story>
</Canvas>

### Responsive (Light text)

<Canvas>
<Story
name="Responsive (Light text)"
parameters={{ backgrounds: { default: "dark" } }}
>
<IcTabContext appearance="light">
<IcTabGroup label="Example tab group">
<IcTab>One</IcTab>
<IcTab>Two</IcTab>
<IcTab>Three</IcTab>
<IcTab>Four</IcTab>
<IcTab>Five</IcTab>
<IcTab>Six</IcTab>
<IcTab>Seven</IcTab>
<IcTab>Eight</IcTab>
<IcTab>Nine</IcTab>
</IcTabGroup>
<IcTabPanel>Tab One</IcTabPanel>
<IcTabPanel>Tab Two</IcTabPanel>
<IcTabPanel>Tab Three</IcTabPanel>
<IcTabPanel>Tab Four</IcTabPanel>
<IcTabPanel>Tab Five</IcTabPanel>
<IcTabPanel>Tab Six</IcTabPanel>
<IcTabPanel>Tab Seven</IcTabPanel>
<IcTabPanel>Tab Eight</IcTabPanel>
<IcTabPanel>Tab Nine</IcTabPanel>
</IcTabContext>
</Story>
</Canvas>

### Playground

export const defaultArgs = {
activationType: "automatic",
appearance: "dark",
disabled: false,
inline: false,
groupLabel: "Example tab group",
theme: "inherit",
monochrome: false,
};

<Canvas>
Expand All @@ -321,22 +260,19 @@ export const defaultArgs = {
type: "inline-radio",
},
},
appearance: {
options: [
"dark", "light"
],
control: {
type: "inline-radio",
},
theme: {
options: ["inherit", "light", "dark"],
control: { type: "inline-radio" },
},
}}
name="Playground"
>
{(args) => (
<div style={{ backgroundColor: args.appearance == "light" ? "black" : ""}}>
<div>
<IcTabContext
activationType={args.activationType}
appearance={args.appearance}
theme={args.theme}
monochrome={args.monochrome}
>
<IcTabGroup
label={args.groupLabel}
Expand Down Expand Up @@ -368,10 +304,14 @@ export const defaultArgs = {
<path d="M9 16.2L4.8 12l-1.4 1.4L9 19 21 7l-1.4-1.4L9 16.2z" />
</svg>
</IcTab>
<IcTab>
Four
</IcTab>
</IcTabGroup>
<IcTabPanel>Tab One</IcTabPanel>
<IcTabPanel>Tab Two</IcTabPanel>
<IcTabPanel>Tab Three</IcTabPanel>
<IcTabPanel>Tab Four</IcTabPanel>
</IcTabContext>
</div>
)}
Expand Down

0 comments on commit 5a9ed1c

Please sign in to comment.