-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar does not update with "no results found" when using external filtering #849
Labels
search-bar component
The generic component, includes both the web component and the React component
Milestone
Comments
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 12, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 12, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading . #849
3 tasks
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 12, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 13, 2023
…ound state Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 13, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 13, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 13, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 13, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 20, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
GCHQ-Developer-530
added a commit
that referenced
this issue
Jul 21, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
jd239
pushed a commit
that referenced
this issue
Jul 24, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
jd239
pushed a commit
that referenced
this issue
Jul 24, 2023
…ound Update search bar to correctly show no results found state when external filtering is used but not loading. Added story to show this. . #849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
search-bar component
The generic component, includes both the web component and the React component
Summary of the bug
When using external filtering with ic-search-bar, the suggestions do not update with "No results found" when passing an empty array as the
options
prop, if there have previously been options supplied. This is causing a problem on the guidance site.🪜 How to reproduce
Using the following code:
🧐 Expected behaviour
The search bar should display "No results found" when given an empty array as options.
📸 Screenshots or code
Additional info
Think this may have been introduced and is masked by the loading state work. Seems to be related to the
preLoad
variable beingtrue
which is preventing the no results text being set.We should maybe add a story into storybook without the loading state but with external filtering
The text was updated successfully, but these errors were encountered: