Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-components): add global primitive and semantic CSS tokens to allow for use in dark mode #2502

Draft
wants to merge 2 commits into
base: v3.0.0/develop
Choose a base branch
from

Conversation

GCHQ-Developer-112
Copy link
Contributor

Summary of the changes

  • Add primitive and semantic CSS token to the global CSS files to allow for use in component tokens and subsequently in dark mode
  • Update primitive and semantic tokens in individual components' CSS files following any renames

BREAKING CHANGE: Work involves the renaming some of the existing CSS tokens following the move towards primitive, semantic and component tokens

Related issue

#2466 #1214

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@GCHQ-Developer-112 GCHQ-Developer-112 force-pushed the 2466-add-new-primitive-and-semantic-tokens-to-the-global-css-files branch 2 times, most recently from 281e726 to eb6a56b Compare September 27, 2024 13:18
@GCHQ-Developer-112 GCHQ-Developer-112 force-pushed the 2466-add-new-primitive-and-semantic-tokens-to-the-global-css-files branch 2 times, most recently from 9f786ab to 1dc7bde Compare September 27, 2024 15:43
… allow for use in dark mode

add primitive and semantic CSS token to the global CSS files to allow for use in component tokens
and subsequently in dark mode. Update primitive and semantic tokens in individual components' CSS
files following any renames.

BREAKING CHANGE: Rename some of the existing CSS tokens following the move towards primitive,
semantic and component tokens

. #2466 #1214
…aming of global tokens

This update is a result of the renaming of existing and addition of new primitive and semantic CSS
tokens

BREAKING CHANGE: Rename some of the existing CSS tokens following the move towards  primitive,
semantic and component tokens

. #2466 #1214
@GCHQ-Developer-112 GCHQ-Developer-112 force-pushed the 2466-add-new-primitive-and-semantic-tokens-to-the-global-css-files branch from 1dc7bde to ac5e504 Compare September 27, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant