Stream Output Error Handling Improvement #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danibix95
reviewed
Jul 10, 2023
hiimjako
force-pushed
the
fix/stream-validation
branch
from
314f4b6
to
2a60ba2
Compare
Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com>
danibix95
approved these changes
Jul 10, 2023
hiimjako
added a commit
to hiimjako/crud-service
that referenced
this pull request
Jul 11, 2023
* 6.8.0-rc.0 * fix(core): handle validation error on stream * 6.8.0-rc.1 * Documentation fix Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com> * docs(core): removed comments * docs: update changelog --------- Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com>
hiimjako
added a commit
to hiimjako/crud-service
that referenced
this pull request
Jul 11, 2023
* 6.8.0-rc.0 * fix(core): handle validation error on stream * 6.8.0-rc.1 * Documentation fix Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com> * docs(core): removed comments * docs: update changelog --------- Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com>
danibix95
added a commit
that referenced
this pull request
Jul 11, 2023
* fix: improve stream output error handling (#125) * 6.8.0-rc.0 * fix(core): handle validation error on stream * 6.8.0-rc.1 * Documentation fix Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com> * docs(core): removed comments * docs: update changelog --------- Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com> * feat(core): make output validation optional * docs(core): changelog.md * perf(core): create ajv output validator on startup --------- Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Currently, the stream output is validated according to the collection schema. However, if a document is not valid, the service crashes as there is no error handling in the output pipeline stream. This PR aims to address this issue by handling the error closing the stream (giving socketError), thereby preventing the CRUD service from crashing.
PR Checklist
Does this PR introduce a breaking change?
Other information