Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/optional stream validation #129

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

hiimjako
Copy link
Contributor

Pull Request Type

  • Feature

Description

The output strict validation in GET and PATCH has been made optional by utilizing the ENABLE_STRICT_OUTPUT_VALIDATION environment variable.

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hiimjako hiimjako requested a review from danibix95 July 11, 2023 12:40
@hiimjako hiimjako force-pushed the feat/optional-stream-validation branch from 9bb1174 to 0307046 Compare July 11, 2023 12:53
hiimjako and others added 3 commits July 11, 2023 15:02
* 6.8.0-rc.0

* fix(core): handle validation error on stream

* 6.8.0-rc.1

* Documentation fix

Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com>

* docs(core): removed comments

* docs: update changelog

---------

Co-authored-by: Daniele Bissoli <danibix95@users.noreply.github.com>
@hiimjako hiimjako force-pushed the feat/optional-stream-validation branch from d17a065 to 1bc4eef Compare July 11, 2023 13:02
Copy link
Collaborator

@danibix95 danibix95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great job!

@danibix95 danibix95 merged commit 89a7036 into mia-platform:main Jul 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants