Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorate httpClient response with duration property #278

Merged
merged 15 commits into from
Nov 17, 2022

Conversation

SimoneBergonzi
Copy link
Contributor

@SimoneBergonzi SimoneBergonzi commented Sep 16, 2022

The httpClient response is decorated with a new property duration indicating the time passed before the call was resolved.
relative issue

Checklist

  • your branch will not cause merge conflict with master
  • run npm test
  • tests are included
  • the documentation is updated or integrated accordingly with your changes
  • the code will follow the lint rules and style of the project
  • you are not committing extraneous files or sensible data

@coveralls
Copy link

coveralls commented Sep 16, 2022

Coverage Status

Coverage decreased (-0.08%) to 97.55% when pulling 8f84150 on feature/http-call-duration into a044368 on master.

Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit e2b6b87 into master Nov 17, 2022
@fredmaggiowski fredmaggiowski deleted the feature/http-call-duration branch November 17, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorate the axios response with the duration of the response.
4 participants