Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/http call duration metrics #280

Merged
merged 9 commits into from
Jan 13, 2023

Conversation

SimoneBergonzi
Copy link
Contributor

@SimoneBergonzi SimoneBergonzi commented Sep 21, 2022

Add metrics to collect http client request duration.
The metric is enabled at service level by mean of the variable ENABLE_HTTP_CLIENT_METRICS (default: false).
The metric can be enabled at service level and disabled for specific proxy or request by mean of proxy/request options.
The url metrics label can be set by request options (default is request url) -> this is to prevent too many labels values for url when calling a parameterized url (e.g: /riders/:id).

related pr

Checklist

  • your branch will not cause merge conflict with master
  • run npm test
  • tests are included
  • the documentation is updated or integrated accordingly with your changes
  • the code will follow the lint rules and style of the project
  • you are not committing extraneous files or sensible data

@coveralls
Copy link

coveralls commented Sep 21, 2022

Coverage Status

Coverage: 94.882% (+0.05%) from 94.828% when pulling 609b2b5 on feature/http-call-duration-metrics into fc31921 on master.

@silversoul93
Copy link
Contributor

@fredmaggiowski is this branch mergeable?

@SimoneBergonzi SimoneBergonzi force-pushed the feature/http-call-duration-metrics branch from 97d1823 to fcdb6ee Compare January 12, 2023 18:22
CHANGELOG.md Show resolved Hide resolved
lib/httpClient.js Outdated Show resolved Hide resolved
@fredmaggiowski fredmaggiowski merged commit be2fb0e into master Jan 13, 2023
@fredmaggiowski fredmaggiowski deleted the feature/http-call-duration-metrics branch January 13, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants