-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log guidelines improvements #10
Conversation
Log samples
|
const importEnv = require('./import-env') | ||
const { exportFastifyOptions, exportServiceOptions } = require('./options-extractors') | ||
const statusRoutes = require('./status-routes') | ||
const swaggerDefinition = require('./swagger-definition') | ||
const WAIT_BEFORE_SERVER_CLOSE_SEC = parseInt(process.env.WAIT_BEFORE_SERVER_CLOSE_SEC) || 10 | ||
|
||
const lc39Options = { | ||
disableRequestLogging: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We lost an error log with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean this one?
https://github.com/fastify/fastify/blob/667d4644eab09f27bc30cad6e7378f5fc82cb9e8/lib/reply.js#L587
In that case it's intended to be disabled: fastify/fastify#2319
Checklist
master
npm test