Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes syntax error #11

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Fixes syntax error #11

merged 1 commit into from
Jan 20, 2016

Conversation

honshu
Copy link
Contributor

@honshu honshu commented Jan 1, 2016

No description provided.

@mibk
Copy link
Owner

mibk commented Jan 4, 2016

Hello.

dupl uses Go 1.4 syntax where for range ... is a valid statement. There is a note in README about the minimal required version. Since it's only this statement that actually requires version 1.4 or above I'm thinking of accepting the PR provided you're in a situation that you can't use a newer version of Go and forking dupl doesn't work for you.

In case of accepting the PR I have some requirements about the code and commit message style.

  1. The code must be gofmted!
  2. There is a more simple notation: for _ = range ... (, _ can be omitted).
  3. The commit message should start with a prefix, dupl: in this case, and should be in imperative mood (fix ..., change ...)
  4. Vim exit shortcuts at the end of the commit message aren't preferred either.

mibk added a commit that referenced this pull request Jan 20, 2016
It allows compiling dupl for versions of Go bellow 1.4.
@mibk mibk merged commit 7866aad into mibk:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants