changed constant definition for new line (NL) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when copying between windows and unix new line may be \r\n value and therefore displays "valid_lft forever preferred_lft forever" instead of veth... address
|
Hi @DaniHaag, sorry for the slow response on this. Thanks for contributing! I wasn't thinking about Windows newlines since it's a shell script, but it seems like this can't hurt. I'll go ahead and merge it in. I think the "valid_lft forever preferred_lft forever" bug is actually something else that's being discussed in #2. |
|
@micahculpepper Thanks for sharing your script. In my opinion this fixes an information need in docker in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when copying between windows and unix new line may be \r\n value and therefore displays
"valid_lft forever preferred_lft forever" instead of veth... address