-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix command splitting and joining when an argument contains spaces #65
Conversation
Changes Unknown when pulling be510cc on emillynge:shlex_splitting into ** on micahhausler:master**. |
@emillynge thanks for making this! Any chance you could squash the 3 commits down to one? |
Changes Unknown when pulling 0cd967e on emillynge:shlex_splitting into ** on micahhausler:master**. |
I would, but it seems like a hassle that is unnecessary since this is actually built-in as a tool for the maintainer. Squash to only one “proper” commit for github pull request
The thread refers to this post Squash your commits |
By the way, I have expanded the code change to the kubernetes, marathon and chronos module as well for consistency. Also I have changed the "unsplitting" slightly as I found out that |
0cd967e
to
472f9b6
Compare
Changes Unknown when pulling 472f9b6 on emillynge:shlex_splitting into ** on micahhausler:master**. |
Found the time to squash to just 1 commit. :) Should be ready to merge without further ado |
I'm thinking @micahhausler maybe didn't get a notification :) Everything should be ready to merge. |
Thanks @emillynge ! |
At the moment ECS and compose transformers performs a "dumb" argument splitting.
This means that the following compose entrypoint:
gets incorrectly transformed into
/bin/echo hello world
which fails as echo only expects 1 argument.conversely ECS emits
'/bin/echo "Hello world"
asThis PR fixes these and adds tests for the failure mode.