Compose: Pass thru list types

[plukevdh]

There's an edge case with Docker Compose command entries that the current code will break.

command: ["bash", "-c", "cmd one ; cmd two"] is supposed to generate a command similar to: bash -c "cmd one ; cmd two".

This ought to generate an ECS task command form of:

"command": [
  "sh",
  "-c",
  "make test ; make run"
]

but instead, it generates

"command": [
  "sh",
  "-c",
  "make",
  "test",
  ";",
  "make",
  "run"
]

Which fails on ECS. This at least fixes the issue I'm seeing, but I'm not entirely aware what else could break.

[emillynge]

Hi @plukevdh
I'm working on this exact problem as well.
I subitted my own PR before i found yours...
Fix command splitting and joining when an argument contains spaces #65

I think your approach may be flawed. ATM the intermediate format for commands is a string which mirrors native docker (Probably because the docker engine uses an HTTP API). I therefore don't think the answer is to change the internal representation to be a list as you have done in this PR.

Furthermore it doesn't fix the real problem, which is that the method str.split is being used to transform a command str to a list. Rather we should be using the shlex.split method which is made for this purpose specifically.

The current implemetation uses this method:

>>> "echo 'hello world'".split()
['echo', "'hello", "world'"]

Which fails..

[plukevdh]

As long as we have a version which works as expected with the strings vs. lists, I'm 👌 . This was my intermediate fix which worked for us. If yours does the same (but more consistently) then I'll swap over to use that instead.

[plukevdh]

Thanks for the feedback and the fix either way!

[emillynge]

This pr fixes same issue as the merged (https://github.com/micahhausler/container-transform/pull/65)[#65]