-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major code refactor #50
Conversation
resty
Outdated
export _resty_path="" | ||
export _resty_nohistory="" | ||
|
||
|
||
# TODO: global var holers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted a typo: "holers" was probably meant to be "holders".
Major update on my PR, here is a recap: Many commits due to try and error process |
Status of the build can be see there: |
2f6fc08
to
42856f6
Compare
42856f6
to
8df27c0
Compare
49ad49c
to
f932da5
Compare
Code was refactored to be made more readable, maintenable, and extendable.
resty function was split in two:
resty
: method to set up the host targetresty-call
: to perform a call on the target (this is the method now called by theGET
,POST
,ETC
functionssome coment where added in the code, and the inline
&&
where replaced with proper test.A switch case was added to handle the options.
You are welcome to do comments on this refactor.
Very welcome. :)
(I might add shpec test before to merge this.)