Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major code refactor #50

Merged
merged 173 commits into from
Nov 7, 2017
Merged

Major code refactor #50

merged 173 commits into from
Nov 7, 2017

Conversation

AdrieanKhisbe
Copy link
Collaborator

Code was refactored to be made more readable, maintenable, and extendable.

resty function was split in two:

  • resty : method to set up the host target
  • resty-call: to perform a call on the target (this is the method now called by the GET,POST,ETC functions

some coment where added in the code, and the inline &&where replaced with proper test.
A switch case was added to handle the options.

You are welcome to do comments on this refactor.
Very welcome. :)

(I might add shpec test before to merge this.)

@AdrieanKhisbe AdrieanKhisbe self-assigned this Mar 9, 2015
@AdrieanKhisbe AdrieanKhisbe added this to the v3.0 milestone Mar 10, 2015
resty Outdated
export _resty_path=""
export _resty_nohistory=""


# TODO: global var holers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted a typo: "holers" was probably meant to be "holders".

@AdrieanKhisbe
Copy link
Collaborator Author

Major update on my PR, here is a recap:
These many commits consist in setting up a test suite that is run on travis.
These test are run on zsh and bash, both on linux and osx.
Some modifications to the code had to be made to be working.

Many commits due to try and error process

@AdrieanKhisbe
Copy link
Collaborator Author

Status of the build can be see there:
https://travis-ci.org/AdrieanKhisbe/resty/builds

@AdrieanKhisbe
Copy link
Collaborator Author

@here @micha
I'm about to merge and make a release candidate version

@AdrieanKhisbe AdrieanKhisbe merged commit 3f64ef2 into micha:beta Nov 7, 2017
@AdrieanKhisbe AdrieanKhisbe deleted the refactor branch November 7, 2017 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants