New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Setup Wizard (Initial Release) #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mission which is on by default and also option to tint it
…Shaders into Add-New-Setup-Scripts-And-File-Explorer-Windows
…gh1/Blender-miHoYo-Shaders into Add-New-Setup-Scripts-And-File-Explorer-Windows
…Explorer-Windows' into Add-Setup-Wizard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Release for the Setup Wizard Tool
IMPORTANT NOTE:
Originally this was for: festivities/Blender-miHoYo-Shaders#3, but I decided to decouple my fork from the Festivity's Shader repo (as these scripts could be later bundled into an addon).
I have merged my forked branch of Festivity's Shaders repo into this new repository (to keep historical commits) and removed his shaders. Hence why you will see Festivity's commits in this PR.
Open to any and all feedback, suggestions, comments, etc.
(I realize there are print statements littered here and there...I can clean them up or we can keep them in case we need to troubleshoot issues down the line)Debug print statements should be mostly cleaned upDesign
The idea behind the design of this tool is to make it easy to add new components (steps) without breaking other components (steps). We can do this by decoupling each component and making them call a common module (
import_order.py
) which acts as an invoker that invokes the next step in the process.The decoupling of the components also allows us to easily re-arrange steps in the workflow as needed (see
config.json
).It also makes each component have a single responsibility and reduces the chances that changes in one component will impact another component.
Flow goes clockwise in diagram:
. . . (and so on)
(Crude Design Diagram of Setup Wizard Tool flow, a few new components have been added since this diagram was created)
Patch Notes since Previous Version (festivities/Blender-miHoYo-Shaders@b167537)
Fixes
• Fixed deleting empties used for Head Driver
• Fixed fbx import missing
automatic_bone_orientation
Features
• Added Setup Head Driver component
• Added Make Character Upright script
• Added force_connect_children when importing character models
• UV1 map will be added when importing character models
• Characters will now be reset to their A-pose when importing character models
• Added Make Color Management 'Standard'
Refactoring
• Character-Material mapping now lives in a json file,character_material_mapping.json
(before it existed in 3 files and adding a new character, like Nahida, would need to be done in 3 places)