Lazy load editor components #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd EditorToolbar. Lazy load Plain and Rich text editors.
…ditor controls. Also lazy load Plain and Rich text editors.
|
This actually solves this bug as well (#2) since we are lazy loading the editor components and don't render them server side. I cannot reproduce that bug with this addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for improvements based on #6 . This PR introduces some awaited / lazy loaded components for the Editor parts.
To simplify for all the pages using the editor tools we wrap the controls under the same name
EditorToolbarthat forwards all props and events to an inner lazy loaded componentEditorControls.PlainText,RichTextandImagewill all be lazy loading their inner parts.