Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PROTOCOL-RMI.md #26

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Conversation

jonesPD
Copy link
Contributor

@jonesPD jonesPD commented Jun 7, 2020

Judging from the values I see returned by my Q350 and what I find in the Comfo Control app, it seems RMOT PropIds for heating and cooling need to be the other way around

Judging from the values I see returned by my Q350 and what I find in the Comfo Control app, it seems RMOT PropIds for heating and cooling need to be the other way around
@michaelarnauts michaelarnauts merged commit dbd6f44 into michaelarnauts:master Jun 7, 2020
@michaelarnauts
Copy link
Owner

Thanks for your PR's! My goal is to rework this library to have an much clearer API, and to be more easy to use and maintain, but all help is welcome!

@hme0354
Copy link

hme0354 commented Jun 7, 2020 via email

@michaelarnauts
Copy link
Owner

I haven't coded it yet, but it will change the way the library will work.

@hme0354
Copy link

hme0354 commented Jun 7, 2020 via email

@michaelarnauts
Copy link
Owner

To refactor it, make it easier to maintain, add features. You can still keep on using the tagged version you are using now.

@Mus1c
Copy link

Mus1c commented Jun 7, 2020

Sure, I hope you will do a release before the big change. The last release 0.3 is from 27 Jun 2017 and in the meantime a lot of commits have been made.
Many thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants