Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full rewrite #30

Open
wants to merge 90 commits into
base: master
from
Open

Full rewrite #30

wants to merge 90 commits into from

Conversation

@michaelbaudino
Copy link
Owner

michaelbaudino commented Feb 4, 2017

This is a full-refactor of the code to have it cleaner, more readable, more DRY and mostly more SRP.

See https://github.com/michaelbaudino/addic7ed-ruby#information_source-upcoming-design-breaking-changes

…sionNormalizer and CommentNormalizer
😕)
…and memoizes the shows list and another service that parses that show list to find out how a given show name is URL-encoded by Addic7ed)
…e concerns and responsabilities
… and SubtitlesCollection classes
…sh-separated main compatible release groups
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 22, 2017

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling f76db56 on full-rewrite into fa38974 on master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 22, 2017

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling f76db56 on full-rewrite into fa38974 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

4 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

Parsing is now based on the multi-languages page of the episode to
prevent random behaviour when no subtitle is found for a given language.

Parsing has been refactored for code clarity (more readable, more SRP),
it is now closer to the webpage DOM hierarchy, it better supports HI
(not only the absence of HI) and it adds support for subtitles marked
as corrected.

The `Search` object has been removed in favour of a more intuitive
class hierarchy.

This is a major breakthrough on the road to 4.0 🎉
@michaelbaudino michaelbaudino self-assigned this Jan 15, 2018
Also, use emoji characters directly in README so they work
within the Yard-generated doc 🎉
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 17, 2018

Coverage Status

Coverage decreased (-9.01%) to 90.986% when pulling 6087568 on full-rewrite into fa38974 on master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 17, 2018

Coverage Status

Coverage decreased (-9.01%) to 90.986% when pulling 6087568 on full-rewrite into fa38974 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 18, 2018

Coverage Status

Coverage decreased (-70.3%) to 29.69% when pulling 3337a7d on full-rewrite into fa38974 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.