Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full rewrite #30

Open
wants to merge 90 commits into
base: master
Choose a base branch
from
Open

Full rewrite #30

wants to merge 90 commits into from

Conversation

michaelbaudino
Copy link
Owner

This is a full-refactor of the code to have it cleaner, more readable, more DRY and mostly more SRP.

See https://github.com/michaelbaudino/addic7ed-ruby#information_source-upcoming-design-breaking-changes

@michaelbaudino
Move download logic to a service object
f832859
@michaelbaudino
Small refactors and renamings in Addic7ed::Episode
79a4050
@michaelbaudino
Rename Addic7edVersionNormalizer and Addic7edCommentNormalizer to Ver…
4198f2a 
…sionNormalizer and CommentNormalizer
@michaelbaudino
Refactor the parser into 2 service objects
8fed841
@michaelbaudino
Refactor how Episode initializes and holds subtitles
3cef498
@michaelbaudino
Minor: update refactor TODO list
62f0c98
@michaelbaudino
Rename all service objects to start with a verb
d51a0c1
@michaelbaudino
Extract services class method to a module
1febbd6
@michaelbaudino
Move models to a subdirectory
b7f2d71
@michaelbaudino
Move models *specs* to a subdirectory (forgotten files from last comm…
eb1a705 
…it 😕)
@michaelbaudino
Refactor ShowList into 2 service objects (a service that downloads …
5dd58e1 
…and memoizes the shows list and another service that parses that show list to find out how a given show name is URL-encoded by Addic7ed)
@michaelbaudino
Refactor URLEncodeShowName to be more readable
8097d68
@michaelbaudino
Require files more smartly
5c3bcb2
@michaelbaudino
Require the gem code in spec_helper rather than in each spec file
72cf33d
@michaelbaudino
Add a console executable because it's handy
387f0b9
@michaelbaudino
Allow network requests from the console
e3c5334
@michaelbaudino
Move logic from Episode model to a new Search model to better separat…
f6fe3ba 
…e concerns and responsabilities
@michaelbaudino
Add Rubocop and comply to it 👮
b299a34
@michaelbaudino
Fix an error with JRuby
c84d715
@michaelbaudino
Enable Rubocop for CodeClimate
4ab73fc
@michaelbaudino
Use config generated by CodeClimate
843bab9
@michaelbaudino
Enable Brakeman engine for Codeship and disable Fixme engine
e40b9f5
@michaelbaudino
Don't use single-line Rubocop disables
2deebfe
@michaelbaudino
Move user agents, languages and URLs to a config file
17c2bab
@michaelbaudino
Minor one-line refactor
25a14ac
@michaelbaudino
Move compatibility and best-subtitle logics to new CheckCompatibility…
57d9c58 
… and SubtitlesCollection classes
@michaelbaudino
Rename Subtitle#via to Subtitle#source
7188b64
@michaelbaudino
Disable Brakeman on CodeClimate as it's Rails-only 😕
928edd3
@michaelbaudino
Add support for normalization of subtitles versions with multiple, da…
676938b 
…sh-separated main compatible release groups
@michaelbaudino
Fix a typo
b5d4836
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling f76db56 on full-rewrite into fa38974 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling f76db56 on full-rewrite into fa38974 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

@coveralls
Copy link

coveralls commented Aug 23, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-2.5%) to 97.531% when pulling 086870d on full-rewrite into fa38974 on master.

@michaelbaudino
Major refactor of models and parsing
a208091 
Parsing is now based on the multi-languages page of the episode to
prevent random behaviour when no subtitle is found for a given language.

Parsing has been refactored for code clarity (more readable, more SRP),
it is now closer to the webpage DOM hierarchy, it better supports HI
(not only the absence of HI) and it adds support for subtitles marked
as corrected.

The `Search` object has been removed in favour of a more intuitive
class hierarchy.

This is a major breakthrough on the road to 4.0 🎉
@michaelbaudino
Explicit some dependencies versions
51591be
@michaelbaudino
Add a few items to the TODO list
59c9de4
@michaelbaudino michaelbaudino self-assigned this Jan 15, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-9.01%) to 90.986% when pulling 6087568 on full-rewrite into fa38974 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 17, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-9.01%) to 90.986% when pulling 6087568 on full-rewrite into fa38974 on master.

@coveralls
Copy link

coveralls commented Jan 18, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-70.3%) to 29.69% when pulling 3337a7d on full-rewrite into fa38974 on master.

@michaelbaudino michaelbaudino mentioned this pull request Feb 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelbaudino michaelbaudino

Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbaudino @coveralls