Improve ifup script UX #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the shell option, if there is any error (e.g. brctl not installed), QEMU will boot regardless. In such case, the error may go unnoticed, given the amount of information dumped on the screen by the boot sequence.
In Ubuntu [20.04] for example, the package is not installed by default.
64kramsystem
force-pushed
the
improve_startup_script_resilience
branch
from
11bbf8d
to
76f026b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ifup script doesn't fail even if the commands run do. The problem with this is that problems can go unnoticed, since the VM boot immediatley prints a wall of text.
This PR makes the VM startup fail if anything in the script fail, and it also gives (marginally) more helpful information in case the bridge tool is not found.