Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it possible to specify -D options at the jvm startup #352

Merged
merged 2 commits into from
Aug 8, 2017
Merged

make it possible to specify -D options at the jvm startup #352

merged 2 commits into from
Aug 8, 2017

Conversation

erebe
Copy link
Contributor

@erebe erebe commented Jun 1, 2017 •
edited
Loading

Hello,

This PR aims to make it possible for the user to specify custom options to pass to cassandra at the jvm startup.

This feature is useful when you want to toggle expiremental features of cassandra

Romain GERARD and others added 2 commits June 1, 2017 12:09
michaelklishin
michaelklishin requested changes Jul 12, 2017
View reviewed changes
templates/default/logback.xml.erb
@@ -50,7 +50,6 @@
</encoder>
</appender>

<% if node['cassandra']['logback']['debug']['enable'] -%>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this essential to this PR? I don't think we should enable debug logging by default?

@michaelklishin
Copy link
Owner

Hi @erebe. Any chance you can address my comment above? Thank you.

@michaelklishin michaelklishin merged commit 6ae8b6a into michaelklishin:master Aug 8, 2017
michaelklishin added a commit that referenced this pull request Aug 8, 2017
@michaelklishin
Revert "logback: always put the stubs for DEBUG"
4ed5a7d 
This reverts commit 6ae8b6a.

There was no explanation provided for this change in #352. Reverting
but keeping the rest.
@erebe
Copy link
Contributor Author

erebe commented Aug 18, 2017 •
edited
Loading

Hello sorry for the delay, but for an unknown reason github haven't delivered me the mail with your comment nor when the PR has been merged.

Regarding your question, the logback: always put the stubs for DEBUG was not intended to be added in the pull request and I don't know why it appeared in the PR as I made it the 1 june and the commit in question is from the 20 june.

@erebe erebe mentioned this pull request Aug 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erebe @michaelklishin