Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API endpoints to remove www prefix #263

Closed
wants to merge 1 commit into from

Conversation

purpleidea
Copy link

On or about 25/Jan/2024, voip.ms changed their server config to remove
the www prefix from their API. This broke all the clients that included
that. This updates the prefix. voip.ms denied breaking things, but it
seems it was the case after all.

On or about 25/Jan/2024, voip.ms changed their server config to remove
the www prefix from their API. This broke all the clients that included
that. This updates the prefix. voip.ms denied breaking things, but it
seems it was the case after all.
@purpleidea
Copy link
Author

Note, I don't have the build infra to test this, but based on user reports, this should be a sensible fix.

@michaelkourlas
Copy link
Owner

I don't typically accept PRs (see https://github.com/michaelkourlas/voipms-sms-client/blob/master/CONTRIBUTING.md) but thanks anyways!

@purpleidea
Copy link
Author

Looks like you just copied my patch and committed it as your own?

5c5a6ee

Not that it's a complicated patch to either write or review, but kind of a strange sort of way to respond.

@michaelkourlas
Copy link
Owner

Replacing "www.voip.ms" with "voip.ms" at each of the httpPostWithMultipartFormData call sites is trivial, and I did so without reference to your patch.

Open source projects can be run in many different ways. Many are open to unsolicited contributions, but this one is not. This is clearly stated in the policy I linked to. In future, please follow the policy and ask before submitting a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants