Fix possible crashes on lost connections while modal dialog is shown #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a modal dialog is shown and in that moment a connection becomes broken, a crash can happen.
There are a lot of examples. To reproduce one of them:
SCP
connectionF8
on some file and see the confirmation dialogssh
process, reconnect vpn, etc)Abort
, thenOk
orCancel
, and get the crashThis PR fixes this problem.