Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible crashes on lost connections while modal dialog is shown #462

Merged
merged 1 commit into from May 5, 2024

Conversation

ssvine
Copy link
Contributor

@ssvine ssvine commented Apr 19, 2024

When a modal dialog is shown and in that moment a connection becomes broken, a crash can happen.

There are a lot of examples. To reproduce one of them:

  1. open SCP connection
  2. press F8 on some file and see the confirmation dialog
  3. simulate broken connection (e.g. kill ssh process, reconnect vpn, etc)
  4. you'll see an error message about broken connection. Press Abort, then Ok or Cancel, and get the crash

This PR fixes this problem.

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@michaellukashov michaellukashov merged commit 0774dcc into michaellukashov:main May 5, 2024
1 of 2 checks passed
@ssvine ssvine deleted the fix-synchro-events branch May 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants