relace contextfilter with pass_context #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
requested changes
Jun 27, 2022
filter_plugins/filters.py
Outdated
| @@ -128,7 +128,7 @@ def _interface_check(context, interface, interface_type=None): | |||
| return _pass() | |||
|
|
|||
|
|
|||
| @jinja2.contextfilter | |||
| @jinja2.pass_context | |||
There was a problem hiding this comment.
This breaks on versions of Jinja2 older than 3.0.0. What I've done elsewhere is this:
# NOTE: jinja2 3.1.0 dropped contextfilter in favour of pass_context.
try:
from jinja2 import pass_context
except ImportError:
from jinja2 import contextfilter as pass_context
There was a problem hiding this comment.
That is something I am also in favor of, thanks!
|
Cool, thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextfilter is deprecated in jinja2 and can be replaced by pass_context
jupyter/nbconvert#1568
Can we please replace contextfilter in filter_plugins/filters.py? Otherwise there is an error with new jinja2:
michaelrigart.interfaces/filter_plugins/filters.py) as it seems to be invalid: module 'jinja2' has no attribute 'contextfilter'