Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always false condition in pappl/system.c #205

Closed
qarmin opened this issue May 22, 2022 · 2 comments
Closed

Always false condition in pappl/system.c #205

qarmin opened this issue May 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working priority-high
Milestone

Comments

@qarmin
Copy link

qarmin commented May 22, 2022

pappl/pappl/system.c

Lines 594 to 601 in 97d7297

else if (system->num_clients < system->max_clients)
{
if (system->num_clients >= system->max_clients)
{
for (i = 0; i < (size_t)system->num_listeners; i ++)
system->listeners[i].events = POLLIN;
}
}

if system->num_clients < system->max_clients is true then opposite condition is always false

@michaelrsweet
Copy link
Owner

Hmm, looks like a copy/paste error. The intent is to restore listening for new connections once the number of clients goes below the preset limit.

@michaelrsweet michaelrsweet self-assigned this May 22, 2022
@michaelrsweet michaelrsweet added bug Something isn't working priority-high labels May 22, 2022
@michaelrsweet michaelrsweet added this to the Stable milestone May 22, 2022
@michaelrsweet
Copy link
Owner

[master e47214d] Fix max-clients code that re-enables listening (Issue #205)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-high
Projects
None yet
Development

No branches or pull requests

2 participants