Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe Connect and Stripe.js customer token support #6

Merged
merged 18 commits into from
Mar 3, 2013

Conversation

lukehoersten
Copy link
Collaborator

This pull request adds two new features:

  • Stripe Connect support. It uses http-conduit. Here are a few future changes to be made:
    • Unify the Stripe API and Stripe Connect http-conduit usage. Both use http-conduit but from different functions. b7adf61
    • The client_id for Stripe Connect should be added to the stripe config object. 3c51167
  • Support for adding and updating Customer objects with a Stripe.js token. This fixes issue Customer objects can't be created with tokens #4

Out of the 8 commits of mine included in this pull request, 6 are cleanups and improvements to Max's "library update patch": #5 which seems to work nicely based on my limited testing.

Happy Holidays!
-Luke

@@ -28,10 +29,12 @@ Library
, Web.Stripe.Utils
Build-depends: base >= 3 && < 5
, text == 0.11.*
, json >= 0.3.6
, network == 2.3.*
, aeson >= 0.6.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so happy to have aeson instead

@michaelschade michaelschade merged commit 2a7ad28 into michaelschade:master Mar 3, 2013
@michaelschade
Copy link
Owner

I fixed a few bugs and finally merged this in. I'm working on updating this to the latest version of our API (and versioning it correctly) and adding tests, but I'll pull those in through a new pull request.

Thanks for the work on this!

@lukehoersten
Copy link
Collaborator Author

Awesome! Thanks for taking the time to do this. Do you plan on making a hackage release? If so, please post here so I can release my Stripe Snaplet.

@dmjio
Copy link
Collaborator

dmjio commented Oct 10, 2013

@michaelschade, Do you plan on releasing the updated version of this on hackage? Trying to use hs-stripe with snap and the network libs are conflicting. @lukehoersten I'd be very interested in seeing your snaplet.

@lukehoersten
Copy link
Collaborator Author

My snaplet is available at LukeHoersten/snaplet-stripe. Again I can't release to hackage until a later version of hs-stripe has been to hackage.

@michaelschade
Copy link
Owner

Hey @dmjio, @lukehoersten -- apologies for the delay here.

Luke, I'm adding you as a contributor to the repo. Just let me know when and I'll get everything updated on Hackage. (Feel free to grab me on gchat; I think you've my email.)

@dmjio
Copy link
Collaborator

dmjio commented Oct 24, 2013

@michaelschade Thanks Michael!

@lukehoersten
Copy link
Collaborator Author

Sounds good. Thanks a lot Michael! I'll get right to it.

@dmjio
Copy link
Collaborator

dmjio commented Nov 11, 2013

@michaelschade any idea on the ETA of when then newer version of hs-stripe will be available on hackage?

@michaelschade
Copy link
Owner

@dmjio apologies for the delay -- all done now! http://hackage.haskell.org/package/stripe-0.3.0.1

@lukehoersten
Copy link
Collaborator Author

@dmjio
Copy link
Collaborator

dmjio commented Dec 1, 2013

@lukehoersten @michaelschade huge, huge thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants