-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe Connect and Stripe.js customer token support #6
Conversation
…anguage directives for non-cabal building.
…g a few features (to be added later)
…arse error messages.
@@ -28,10 +29,12 @@ Library | |||
, Web.Stripe.Utils | |||
Build-depends: base >= 3 && < 5 | |||
, text == 0.11.* | |||
, json >= 0.3.6 | |||
, network == 2.3.* | |||
, aeson >= 0.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so happy to have aeson instead
I fixed a few bugs and finally merged this in. I'm working on updating this to the latest version of our API (and versioning it correctly) and adding tests, but I'll pull those in through a new pull request. Thanks for the work on this! |
Awesome! Thanks for taking the time to do this. Do you plan on making a hackage release? If so, please post here so I can release my Stripe Snaplet. |
@michaelschade, Do you plan on releasing the updated version of this on hackage? Trying to use hs-stripe with snap and the network libs are conflicting. @lukehoersten I'd be very interested in seeing your snaplet. |
My snaplet is available at LukeHoersten/snaplet-stripe. Again I can't release to hackage until a later version of hs-stripe has been to hackage. |
Hey @dmjio, @lukehoersten -- apologies for the delay here. Luke, I'm adding you as a contributor to the repo. Just let me know when and I'll get everything updated on Hackage. (Feel free to grab me on gchat; I think you've my email.) |
@michaelschade Thanks Michael! |
Sounds good. Thanks a lot Michael! I'll get right to it. |
@michaelschade any idea on the ETA of when then newer version of hs-stripe will be available on hackage? |
@dmjio apologies for the delay -- all done now! http://hackage.haskell.org/package/stripe-0.3.0.1 |
@lukehoersten @michaelschade huge, huge thanks! |
This pull request adds two new features:
client_id
for Stripe Connect should be added to the stripe config object. 3c51167Out of the 8 commits of mine included in this pull request, 6 are cleanups and improvements to Max's "library update patch": #5 which seems to work nicely based on my limited testing.
Happy Holidays!
-Luke