Stripe Connect and Stripe.js customer token support #6

Merged
merged 18 commits into from Mar 3, 2013

Projects

None yet

4 participants

@LukeHoersten
Collaborator

This pull request adds two new features:

  • Stripe Connect support. It uses http-conduit. Here are a few future changes to be made:
    • Unify the Stripe API and Stripe Connect http-conduit usage. Both use http-conduit but from different functions. b7adf61
    • The client_id for Stripe Connect should be added to the stripe config object. 3c51167
  • Support for adding and updating Customer objects with a Stripe.js token. This fixes issue michaelschade/hs-stripe#4

Out of the 8 commits of mine included in this pull request, 6 are cleanups and improvements to Max's "library update patch": michaelschade/hs-stripe#5 which seems to work nicely based on my limited testing.

Happy Holidays!
-Luke

@maxcan
maxcan commented on 06f7f0b Dec 31, 2012

A pretty import is a happy import.

@maxcan
maxcan commented on ed344ba Dec 31, 2012

point{ free | less } programming FTW!

to be honest, I'm always conflicted about these kind of changes. they're slicker but do make the code a bit harder to read. anyway, I'm mostly indifferent and fine with it.

Owner

Agreed. I figured in this case the function is simple enough that it's worth it and the signature is clear enough.

@maxcan
maxcan commented on 3d074da Dec 31, 2012

nice

@maxcan
maxcan commented on 1762c88 Dec 31, 2012

Always a fan of commits that start with "Following Max's lead"

@michaelschade michaelschade commented on the diff Jan 12, 2013
stripe.cabal
@@ -28,10 +29,12 @@ Library
, Web.Stripe.Utils
Build-depends: base >= 3 && < 5
, text == 0.11.*
- , json >= 0.3.6
- , network == 2.3.*
+ , aeson >= 0.6.1
@michaelschade
michaelschade Jan 12, 2013 Owner

so happy to have aeson instead

@michaelschade michaelschade merged commit 2a7ad28 into michaelschade:master Mar 3, 2013
@michaelschade
Owner

I fixed a few bugs and finally merged this in. I'm working on updating this to the latest version of our API (and versioning it correctly) and adding tests, but I'll pull those in through a new pull request.

Thanks for the work on this!

@LukeHoersten
Collaborator

Awesome! Thanks for taking the time to do this. Do you plan on making a hackage release? If so, please post here so I can release my Stripe Snaplet.

@dmjio
Collaborator
dmjio commented Oct 10, 2013

@michaelschade, Do you plan on releasing the updated version of this on hackage? Trying to use hs-stripe with snap and the network libs are conflicting. @LukeHoersten I'd be very interested in seeing your snaplet.

@LukeHoersten
Collaborator

My snaplet is available at LukeHoersten/snaplet-stripe. Again I can't release to hackage until a later version of hs-stripe has been to hackage.

@michaelschade
Owner

Hey @dmjio, @LukeHoersten -- apologies for the delay here.

Luke, I'm adding you as a contributor to the repo. Just let me know when and I'll get everything updated on Hackage. (Feel free to grab me on gchat; I think you've my email.)

@dmjio
Collaborator
dmjio commented Oct 24, 2013

@michaelschade Thanks Michael!

@LukeHoersten
Collaborator

Sounds good. Thanks a lot Michael! I'll get right to it.

@dmjio
Collaborator
dmjio commented Nov 11, 2013

@michaelschade any idea on the ETA of when then newer version of hs-stripe will be available on hackage?

@michaelschade
Owner

@dmjio apologies for the delay -- all done now! http://hackage.haskell.org/package/stripe-0.3.0.1

@dmjio
Collaborator
dmjio commented Dec 1, 2013

@LukeHoersten @michaelschade huge, huge thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment