Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Stripe Connect and Stripe.js customer token support #6

Merged
merged 18 commits into from

4 participants

@LukeHoersten
Collaborator

This pull request adds two new features:

  • Stripe Connect support. It uses http-conduit. Here are a few future changes to be made:
    • Unify the Stripe API and Stripe Connect http-conduit usage. Both use http-conduit but from different functions. b7adf61
    • The client_id for Stripe Connect should be added to the stripe config object. 3c51167
  • Support for adding and updating Customer objects with a Stripe.js token. This fixes issue michaelschade/hs-stripe#4

Out of the 8 commits of mine included in this pull request, 6 are cleanups and improvements to Max's "library update patch": michaelschade/hs-stripe#5 which seems to work nicely based on my limited testing.

Happy Holidays!
-Luke

@maxcan

A pretty import is a happy import.

@maxcan

point{ free | less } programming FTW!

to be honest, I'm always conflicted about these kind of changes. they're slicker but do make the code a bit harder to read. anyway, I'm mostly indifferent and fine with it.

Collaborator

Agreed. I figured in this case the function is simple enough that it's worth it and the signature is clear enough.

@maxcan

nice

@maxcan

Always a fan of commits that start with "Following Max's lead"

@michaelschade michaelschade commented on the diff
stripe.cabal
@@ -28,10 +29,12 @@ Library
, Web.Stripe.Utils
Build-depends: base >= 3 && < 5
, text == 0.11.*
- , json >= 0.3.6
- , network == 2.3.*
+ , aeson >= 0.6.1
@michaelschade Owner

so happy to have aeson instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@michaelschade michaelschade merged commit 2a7ad28 into michaelschade:master
@michaelschade

I fixed a few bugs and finally merged this in. I'm working on updating this to the latest version of our API (and versioning it correctly) and adding tests, but I'll pull those in through a new pull request.

Thanks for the work on this!

@LukeHoersten
Collaborator

Awesome! Thanks for taking the time to do this. Do you plan on making a hackage release? If so, please post here so I can release my Stripe Snaplet.

@dmjio
Collaborator

@michaelschade, Do you plan on releasing the updated version of this on hackage? Trying to use hs-stripe with snap and the network libs are conflicting. @LukeHoersten I'd be very interested in seeing your snaplet.

@LukeHoersten
Collaborator

My snaplet is available at LukeHoersten/snaplet-stripe. Again I can't release to hackage until a later version of hs-stripe has been to hackage.

@michaelschade

Hey @dmjio, @LukeHoersten -- apologies for the delay here.

Luke, I'm adding you as a contributor to the repo. Just let me know when and I'll get everything updated on Hackage. (Feel free to grab me on gchat; I think you've my email.)

@dmjio
Collaborator

@michaelschade Thanks Michael!

@LukeHoersten
Collaborator

Sounds good. Thanks a lot Michael! I'll get right to it.

@dmjio
Collaborator

@michaelschade any idea on the ETA of when then newer version of hs-stripe will be available on hackage?

@michaelschade

@dmjio apologies for the delay -- all done now! http://hackage.haskell.org/package/stripe-0.3.0.1

@dmjio
Collaborator

@LukeHoersten @michaelschade huge, huge thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 15, 2012
  1. @maxcan
  2. @maxcan

    coupon now compiles

    maxcan authored
Commits on Jun 18, 2012
  1. @maxcan
  2. @maxcan
Commits on Jun 19, 2012
  1. @maxcan

    code cleanup

    maxcan authored
Commits on Jun 22, 2012
  1. @maxcan

    killed some debug printing code

    maxcan authored
Commits on Jun 26, 2012
  1. @maxcan
Commits on Jul 10, 2012
  1. @maxcan

    added to gitignore

    maxcan authored
Commits on Dec 22, 2012
  1. @LukeHoersten

    Cleaned up some formatting with stylish-haskell and added necessary l…

    LukeHoersten authored
    …anguage directives for non-cabal building.
  2. @LukeHoersten
  3. @LukeHoersten
  4. @LukeHoersten
  5. @LukeHoersten
  6. @LukeHoersten
Commits on Dec 23, 2012
  1. @LukeHoersten
  2. @LukeHoersten

    Added basic Stripe Connect functionality. Fully functional but lackin…

    LukeHoersten authored
    …g a few features (to be added later)
Commits on Dec 28, 2012
  1. @LukeHoersten

    Added missing export.

    LukeHoersten authored
Commits on Dec 31, 2012
  1. @LukeHoersten
Something went wrong with that request. Please try again.