fix 'over scrolling' bug #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DO NOT merge this branch. It has severe bug of wrong scrolling. My textFields are jumping to a very wrong position on dismiss by using above code. No issue with existing code |
|
Cheers for the review @tariq235! Going to close this one. |
|
what's wrong with this piece of code? in what case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the text field is at the very bottom of the scrollView, by the time keyboard dismiss, you will see a ‘over scroll gap’ at the bottom, the contentOffest has wrong value. then slightly touch the scrollView, it jump to the correct value.